package.erb: Fix links to repository URL #1344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently some instructions like openSUSE or Debian link to e.g. /repositories/hardware:razer/ instead of /repositories/hardware:/razer/ with an extra slash but the version without the extra slash return HTTP 404 and therefore don't work. Make sure to add the path fixup everywhere where the v[:repo] variable is used. Fixes openSUSE#1142 Fixes openSUSE#1273
|
Apparently e.g. |
|
I think this PR is now redundant since the issue is no longer there. The URLs have not changed, it looks like the link no longer 404s. Probably a back-end change? |
|
In any case for consistency it's good to use the same URL template for the repos, but yes as I wrote in the comment before something changed on the download.opensuse.org side that both paths work again, but I'm not confident it won't break again at some point in the future. Maintenance of these repos is also a bit, well, lackluster. |
|
@hennevogel review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some instructions like openSUSE or Debian link to e.g. /repositories/hardware:razer/ instead of /repositories/hardware:/razer/ with an extra slash but the version without the extra slash return HTTP 404 and therefore don't work.
Make sure to add the path fixup everywhere where the v[:repo] variable is used.
Fixes #1142
Fixes #1273
Please note that I didn't test this change since I don't have the dev environment set up and this should be quite easy to validate for someone who has. Issue also seen on https://software.opensuse.org/download.html?project=hardware%3Arazer&package=polychromatic with "openSUSE Tumbleweed" or https://software.opensuse.org/download.html?project=hardware%3Arazer&package=razergenie with "Debian Unstable" the line with
Release.key